Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32-S2 PSRAM Support #493

Merged
merged 3 commits into from
Apr 26, 2023
Merged

ESP32-S2 PSRAM Support #493

merged 3 commits into from
Apr 26, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Apr 25, 2023

This adds basic support for PSRAM on ESP32-S2 and adding an example how to use PSRAM as heap via eps-alloc

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the example also works fine for me.

@bjoernQ bjoernQ merged commit a950a3b into esp-rs:main Apr 26, 2023
@bjoernQ bjoernQ deleted the feature/ESP32-S2-PSRAM branch April 26, 2023 06:55
@bjoernQ bjoernQ mentioned this pull request Apr 26, 2023
@jessebraham
Copy link
Member

jessebraham commented Apr 26, 2023

This got merged before I got a chance to look at it, but just curious why the S3's lib.rs is being modified if this PR is for the S2? I assume that wasn't meant to be included?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Apr 26, 2023

This got merged before I got a chance to look at it, but just curious why the S3's lib.rs is being modified if this PR is for the S2? I assume that wasn't meant to be included?

It's intended - as well as ESP32 (and for the RVs in another way) - it's in preparation to always call common_init ... while it's not doing anything for the other chips yet (but soon it will)

@jessebraham
Copy link
Member

Ahh sorry I didn't notice the ESP32 was updated as well, that makes more sense now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants