Skip to content

Correct endianness of RMT signal in neopixel example - #195

Merged
ivmarkov merged 3 commits into
esp-rs:masterfrom
musdom:patch-1
Jan 14, 2023
Merged

Correct endianness of RMT signal in neopixel example#195
ivmarkov merged 3 commits into
esp-rs:masterfrom
musdom:patch-1

Conversation

@musdom

@musdom musdom commented Dec 24, 2022

Copy link
Copy Markdown
Contributor

Bits were sent reversed, which worked for 0xff but not at smaller values to dim the LED. Also added rainbow example using a hsv function.

Bits were sent reversed, which worked for 0xff but not at smaller values to dim the LED. Also added rainbow example using a hsv function.
@ivmarkov

Copy link
Copy Markdown
Collaborator

Thanks!

@ivmarkov

Copy link
Copy Markdown
Collaborator

@musdom You need to fix the formatting though, if you could do that?

@musdom

musdom commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

@ivmarkov could be because I copy pasted code into github editor from vscode. This time I ran it through cargo fmt. Is it better? Thanks

@musdom

musdom commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Wait let me fix the build failures

@ivmarkov

ivmarkov commented Jan 12, 2023

Copy link
Copy Markdown
Collaborator

Wait let me fix the build failures

Since the examples folder is part of esp-idf-hal, I think you should be importing crate:: not esp_idf_hal::.

Update: BS ^^^ :)

@ivmarkov

Copy link
Copy Markdown
Collaborator

The problem is that from within esp-idf-hal you cannot use, or depend on esp-idf-svc, as esp-idf-svc itself depends on esp-idf-hal. Just replace all logging code with simple println! as all other examples do.

@musdom

musdom commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Ok I actually cloned my fork of the repo, got the patch built and flashed into my board and working correctly, which is something I should've done in the first place :x My bad!

@ivmarkov
ivmarkov merged commit 28a3aad into esp-rs:master Jan 14, 2023
@musdom
musdom deleted the patch-1 branch January 14, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants