Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct endianness of RMT signal in neopixel example #195

Merged
merged 3 commits into from
Jan 14, 2023

Conversation

musdom
Copy link
Contributor

@musdom musdom commented Dec 24, 2022

Bits were sent reversed, which worked for 0xff but not at smaller values to dim the LED. Also added rainbow example using a hsv function.

Bits were sent reversed, which worked for 0xff but not at smaller values to dim the LED. Also added rainbow example using a hsv function.
@ivmarkov
Copy link
Collaborator

Thanks!

@ivmarkov
Copy link
Collaborator

@musdom You need to fix the formatting though, if you could do that?

@musdom
Copy link
Contributor Author

musdom commented Jan 12, 2023

@ivmarkov could be because I copy pasted code into github editor from vscode. This time I ran it through cargo fmt. Is it better? Thanks

@musdom
Copy link
Contributor Author

musdom commented Jan 12, 2023

Wait let me fix the build failures

@ivmarkov
Copy link
Collaborator

ivmarkov commented Jan 12, 2023

Wait let me fix the build failures

Since the examples folder is part of esp-idf-hal, I think you should be importing crate:: not esp_idf_hal::.

Update: BS ^^^ :)

@ivmarkov
Copy link
Collaborator

The problem is that from within esp-idf-hal you cannot use, or depend on esp-idf-svc, as esp-idf-svc itself depends on esp-idf-hal. Just replace all logging code with simple println! as all other examples do.

@musdom
Copy link
Contributor Author

musdom commented Jan 12, 2023

Ok I actually cloned my fork of the repo, got the patch built and flashed into my board and working correctly, which is something I should've done in the first place :x My bad!

@ivmarkov ivmarkov merged commit 28a3aad into esp-rs:master Jan 14, 2023
@musdom musdom deleted the patch-1 branch January 14, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants