Pull out shared bus #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please provide a short summary of what this pull request exactly is doing? To me, it seems like you just renamed |
|
Sorry I took so long to get back to you. I've updated the first comment with a short summary. I didn't rename |
|
After reading the esp-idf doc on the SPI driver, I change my mind. |
|
Obsoleted by #61 |
usbalbin
pushed a commit
to usbalbin/esp-idf-hal
that referenced
this pull request
May 5, 2022
* More ergonomic async traits * Use AtomicWaker * Get rid of the callback Result return * More work on async compat * Async work * Switch all traits to a single error type * Make Eth & Wifi API implementations fully async * Rename Service to Errors * New version * Fix non-experimental build * Fix non-experimental build * Merge fix from @anichno * Again clippy warnings * Again clippy warnings
maximeborges
pushed a commit
to yaak-ai/esp-idf-hal
that referenced
this pull request
Jun 7, 2022
…Waveshare board and 4.2" e-paper screen (esp-rs#52) Signed-off-by: simon <Simon Tropée> Co-authored-by: simon <Simon Tropée>
|
@Dominaezzz I've been trying to read files from an sd card using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to create multiple devices on one bus.
The current SPI interface allows one to create a single
Masterstruct which represents the spi bus and the device.This prevents one from communicating with multiple SPI devices on the same bus. In my case, I have an E-Ink display and an SD card on the same bus and I'm only able to use one at a time.
This PR pulls out the spi bus from the
Masterstruct into aBusstruct, which allows one to create multipleMasters on the same bus.The one thing I wasn't too sure about is whether
Busshould be a struct or trait. I've got with struct for the moment. I don't really see the need for a trait atm.