Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esp-now support #121

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Add esp-now support #121

merged 2 commits into from
Feb 6, 2023

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 6, 2023

This adds support for esp-now ( https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/network/esp_now.html ) for all targets

closes #59

This also makes the xtask work on Windows (and hopefully doesn't break it on other OSes)

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!!! Async too 🤩! Working very well for me here, tried a few chips and all seem to work well :).

Just one small nit about features, my personal preference would be to unify to - but I'm not that bothered.

esp-wifi/Cargo.toml Outdated Show resolved Hide resolved
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Feb 6, 2023

Oh yes - I also prefer to use -
Done 😃

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider support for ESP-NOW
2 participants