Skip to content

Commit

Permalink
Follow suit with xtensa-esp32s2-espidf
Browse files Browse the repository at this point in the history
  • Loading branch information
workingjubilee committed Oct 29, 2023
1 parent 9be95fb commit 2ea63cb
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions compiler/rustc_target/src/spec/xtensa_esp32s2_espidf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,15 @@ pub fn target() -> Target {

// See https://github.com/espressif/rust-esp32-example/issues/3#issuecomment-861054477
//
// Unlike the original ESP32 chip, ESP32-S2 does not really support atomics.
// If the missing hardware instruction ends up being emulated in ESP-IDF, we might want to revert
// this change and claim that atomics are supported "in hardware" (even though they would be emulated
// by actually trapping the illegal instruction exception handler and calling into an ESP-IDF C emulation code).
// While the ESP32-S2 chip does not natively support atomics, ESP-IDF does support
// the __atomic* and __sync* compiler builtins. Setting `max_atomic_width` and `atomic_cas`
// and `atomic_cas: true` will cause the compiler to emit libcalls to these builtins.
//
// However, for now we simultaneously claim "max_atomic_width: Some(64)" **and** atomic_cas: true,
// which should force the compiler to generate libcalls to functions that emulate atomics
// and which are already implemented in the ESP-IDF main branch anyway.
max_atomic_width: Some(64),
// Support for atomics is necessary for the Rust STD library, which is supported by ESP-IDF.
max_atomic_width: Some(32),
atomic_cas: true,

..super::xtensa_base::opts()
},
}
}
}

0 comments on commit 2ea63cb

Please sign in to comment.