-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aulx.CSS constructor, CSS State Machine, and much more. #5
Conversation
This removes aural CSS property names. They are not supported by any browser anyways.
Next step. Fix up any regressions caused till now.
Also removed two useless and confusing files.
Need to add more test regarding STATE machine.
with tests !
@@ -706,6 +706,6 @@ UnicodeRangeToken.prototype.contains = function(code) { | |||
|
|||
// Exportation. | |||
// TODO: also export the various tokens objects? | |||
exports.tokenize = tokenize; | |||
exports.CSS.tokenize = tokenize; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't do that, tokenizer.js is an upstream library. Updating it (which I'm told we should do in about a month) would break this.
Use UMD, similar to how we do with Aulx and Esprima's tokenizer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its just a one line change. Also, when we update from upstream, we can make this change again. I do not want to complicate things using the custom made wrapper. Or else, we can remove this change and access the tokenizer via Aulx.tokenize path instead of Aulx.CSS.tokenize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I say "can't do that", I mean it. If you want, I'll do it when I find time.
Great work, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused now.
Had to remove white space stripping as there was no way to distinguish selectors like "a.class" from "a .class".
That's it for now. I will not be having internet access to be development box for like 10 days now so this pull request is complete. Next pull request will contain demo site upgrades to show up both JS and CSS completion in action. And regression fixes if any. Also, I have to add tests to see if selector state is determined properly. Then later on I will see if attribute and value completion is possible too. |
A few things.
|
Please match the points to the questions:
|
On Thu, Aug 15, 2013 at 7:23 PM, Girish Sharma notifications@github.com wrote:
When copy-and-pasting aulx.js into aulx-ui.js in make.js, you
Huh, I see. I might want to change JS's getContext() to resolveContext() then. |
On Fri, Aug 16, 2013 at 1:06 AM, Thaddee Tyl notifications@github.comwrote:
Girish Sharma |
This pull request contains:
global
passed to Aulx