Revert PR 1769 (fixes #1826)

[AucaCoyan]

I've been git bisecting and found 2 problems,
one, the build of the dpkg with the old ubuntu distro (18.04) is messing with modern debian distributions. It installs with gtk3.0 but it has been deprecated in debian 12 (and ubuntu 22.04 I believe). I solved this by writing a manual script to compile a .deb file and running manually the script in every bisect.

#!/bin/bash
set -e
echo "Installing cargo-deb"
cargo install cargo-deb --version 1.44.1

echo "Building Wayland deb package"
cargo deb -p espanso --variant wayland -- --no-default-features --features "modulo wayland vendored-tls"

cp target/debian/espanso-wayland*.deb espanso-debian-wayland-amd64.deb
echo "  Done!"

This works allright, except the dependencies written in espanso/Cargo.toml aren't quite right, causing installation failures (#1793, #1739, #1662 )
So this led me to write

depends = "$auto"

on the wayland

These PRs #1697 #1769 are rolled back in this proposal. The problem with the second is that is pointed to Hyperland, a minor desktop enviroment, while Wayland is broken in many PCs. (#1826 )

I don't know how to provide another solution to the issues #1768 and #1750. Maybe updating client-toolkit to their latest version, v0.18.1, we'll see..

this fixes #1793

Instructions to try this PR:

checkout the git branch:

git clone -b revert-PR-1769 https://github.com/AucaCoyan/espanso
cd espanso/

install the dependencies:

cargo install rust-script --version "0.7.0"
cargo install --force cargo-make --version 0.37.5
sudo apt install libx11-dev libxtst-dev libxkbcommon-dev libdbus-1-dev libwxgtk3.2-dev

and then compile the .dpkg

#!/bin/bash
set -e
echo "Installing cargo-deb"
cargo install cargo-deb --version 1.44.1

echo "Building Wayland deb package"
cargo deb -p espanso --variant wayland -- --no-default-features --features "modulo wayland vendored-tls"

cp target/debian/espanso-wayland*.deb espanso-debian-wayland-amd64.deb
echo "  Done!"

[morgan-dgk]

fyi, I think this is likely to break espanso on any wl_roots based compositors, not just Hyprland

[AucaCoyan]

Oh thanks! I read a lot about wayland yesterday and found out that is a hot topic in the linux community.
I would like to try and debug the problem, so we can move forward, but currently I use Debian with a pc that has an Nvidia card. Hyprland is out of the park for me. Can you give me a hint of any other wayland compositor that depends on wlroots?

[morgan-dgk]

It's certainly seems to be contentious 😅. From what I can tell, Sway seems to be reasonably popular.

[federico-terzi]

Hey!

one, the build of the dpkg with the old ubuntu distro (18.04) is messing with modern debian distributions. It installs with gtk3.0 but it has been deprecated in debian 12 (and ubuntu 22.04 I believe).

AFAIK, we should build on the oldest version we are planning to support. If we start building on images using ubuntu 22.04, older distros might break... It's a tricky balance, that's why it's so common to build from sources on Linux

I'm also not sure if putting $auto is the right choice, as we moved away from it recently due to different issues: https://github.com/espanso/espanso/pull/1697/files

I don't have a good solution for this, so feel free to continue experimenting. Let's just make sure that we don't break more things than we are trying to fix :)

[AucaCoyan]

Yes, we are not ready with this. I would like to fix the hyprland bug, but so far I had no success with my pc.

[AucaCoyan]

I couldn't setup my pc to debug hyprland 😢 .
I'm between a rock and a hard place, I don't want to merge this because it will cause the bug in wl_roots, but at the same time if I don't merge it the fix for 1826 isn't going to land.

I'm in need of help, what do you think merging this to a temporary branch and some other contributor try to solve the wl_roots problem? I'm not happy with breaking dev and wait for somebody else to fix it.
👂🏼 I'm listening to options here 👂🏼

[morgan-dgk]

I couldn't setup my pc to debug hyprland 😢 . I'm between a rock and a hard place, I don't want to merge this because it will cause the bug in wl_roots, but at the same time if I don't merge it the fix for 1826 isn't going to land.

I'm in need of help, what do you think merging this to a temporary branch and some other contributor try to solve the wl_roots problem? I'm not happy with breaking dev and wait for somebody else to fix it. 👂🏼 I'm listening to options here 👂🏼

#1891 should fix this 🙂

[AucaCoyan]

Excellent! Thank you for your help!

[morgan-dgk]

can we close this @AucaCoyan or are there still changes we need here?

[AucaCoyan]

Yes! I double checked the debian build script is ok, but that can be discussed in another issue.
Closing!