New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a debug option for espanso when executing shell commands for greater context. #359
Adds a debug option for espanso when executing shell commands for greater context. #359
Conversation
Version 0.6.0
Version 0.6.1
Version 0.6.2
Version 0.6.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Thank you for your contribution! I left you only a minor comment and then we are ready to go :)
Keep in mind that all changes are first merged into the dev
branch and then, when releasing a new version, they get merged into master.
Cheers :)
Hey @deckarep, |
Sounds good @federico-terzi! One question would you also be interested in PRs that provide optimizations both big and small? Some examples that come to mind I see are PRs where owned strings are allocated instead of using references. Of course bigger optimizations could be present in hot paths that might be more impactful. |
@deckarep In general, I'd like to discuss all the PRs that get proposed as I really want to avoid wasting people time :) I originally started espanso to learn Rust, so some of the early work was definitely not idiomatic. If I had the time, I would completely re-write it from scratch now that I have much better knowledge, but that would be mostly for aesthetics as espanso is already fast enough for most use-cases. |
Merged, thanks for the help :) |
In reference to the following: #355
I've added a
debug
flag for shell commands to utilize.false
.false
.