Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing function definition (TranslateClauseWithTerminator) #1878

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

danemadsen
Copy link
Contributor

This function was added to the translate.h header in #1811 but the associated function definition was not added to translate.c

@iSuslov
Copy link

iSuslov commented Apr 9, 2024

Hey @danemadsen, do you think we need to add additional modifications with ESPEAK_API as it's implemented here: ba13f63

@jaacoppi jaacoppi merged commit b864eac into espeak-ng:master Jun 15, 2024
78 of 83 checks passed
@sthibaul
Copy link
Collaborator

sthibaul commented Jul 1, 2024

There was an unrelated drop of memset(number_buf, 0, sizeof(number_buf));, which was caught by CI, but ignored for some time. That's confirmed with

https://github.com/espeak-ng/espeak-ng/actions/runs/9749747800 (CI re-run before commit, works)
https://github.com/espeak-ng/espeak-ng/actions/runs/9749753923 (CI re-run with the commit, fails)
https://github.com/espeak-ng/espeak-ng/actions/runs/9749896365 (CI run with memset restored, works)

Please do not ignore CI failures, they are protections against security issues.

This is getting fixed by #1942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants