Fix for newer versions of emscripten #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix in order to compile the emscripten demo with recent versions of emscripten.
The default behaviour of emscripten is now to compile with WASM option, generating a different data file and forcing async loading. For now, I propose to just stay the closest as possible to what was done before and keep a sync loading by just using WASM=0.
File System function import in the module has also become an option in emscripten, and we absolutely need it, so the flag should be passed explicitly : FORCE_FILESYSTEM=1
The Runtime functions are now imported directly without scoping the Runtime module: updated accordingly.
That's all for the changes.