Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fan direction #8

Merged
merged 2 commits into from Dec 14, 2020
Merged

Conversation

blejdfist
Copy link
Contributor

This adds support for fan direction

Relevant pull requests
esphome/esphome-docs#580
esphome/esphome#1051

@glmnet
Copy link
Member

glmnet commented Jun 14, 2020

Well.. regarding the protoc generation I don't know why Otto is still generating those files with old python 2 utf headers.

Anyway, this is stuck without him, I am not really expert in python, but even if we commit to aioesphome this, and bump version, the library will not reach pyp magically (I guess) and we will go no further than that. Am I right with this reasoning?

@blejdfist
Copy link
Contributor Author

@glmnet Maybe it was just an older version of the protobuf compiler? I used version 3.6.1 (current version in Ubuntu 20.04).

You are probably right, if this is merged it will not reach pypi automatically.
There doesn't seem to be any automation in this repo.

What is your opinion on merging esphome/esphome#1051 (+ documentation) in the meanwhile?
It does not require the changes to aioesphome to be merged at the same time since protobuf will simply ignore fields it does not know about).

@blejdfist
Copy link
Contributor Author

@glmnet It seems like the utf-8 headers in the generated files are now gone on master as well so the diff is cleaner now.

@glmnet
Copy link
Member

glmnet commented Dec 14, 2020

@blejdfist seems like your code finally went thru, now you'll need to re-open the PR at HA

@blejdfist
Copy link
Contributor Author

@glmnet That's great, I was starting to loose hope :)
I'll look into it as soon as I can.

@blejdfist blejdfist deleted the fan_improvements branch December 23, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants