Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for climate integrations to support eco mode #1075

Closed
wants to merge 2 commits into from

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented May 27, 2020

Description:

Add support for climate devices to set eco_mode on or off.
To be used this would need to be implemented also in API clients such as homeassistant as a preset mode for the climate entity.

Related issue (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#627

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@glmnet glmnet added the climate label Jun 7, 2020
@glmnet
Copy link
Member

glmnet commented Jul 14, 2020

Does this one requires also an update on the aioesphomeapi and the home assistant integration?

There is a pending PR esphome/aioesphomeapi#8 on fan waiting for Otto, actually what we need there is update the aioesphome library update the pypi, that repo needs the action to publish to pypi too, I believe the twine secrets are already available.

@jesserockz
Copy link
Member Author

Yes it would. I have not looked into writing that part yet though.

I can look into writing a GH action for it though.

@blademckain
Copy link

ECO, as well as AWAY should be presets supported by the climate component, like the other presets indicated here

To be closer to the home assistant logic,
they should not be handled with a true / false Boolean
but with a list in which to indicate which presets it supports and the possibility of also having custom presets

@jesserockz
Copy link
Member Author

ECO, as well as AWAY should be presets supported by the climate component, like the other presets indicated here

To be closer to the home assistant logic,
they should not be handled with a true / false Boolean
but with a list in which to indicate which presets it supports and the possibility of also having custom presets

I totally agree with you there and it's why I have not gone further with adding support for this specific eco_mode in aioesphomeapi too.

@jesserockz jesserockz closed this Jul 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants