This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Revert ultrasonic sensor to non-interrupt mode #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoWinter
added a commit
that referenced
this pull request
Mar 24, 2019
This reverts commit cf84e09.
OttoWinter
added a commit
that referenced
this pull request
Mar 31, 2019
* Fix ultrasonic sensor * Fix default poll interval * Revert to non-interrupt implementation * Lint * Update ultrasonic_sensor.cpp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The ultrasonic sensors must be generating a short pulse on the echo pin when trigger is pulsed. No good way to fix that with interrupt mode.
Related issue (if applicable): fixes esphome/issues#147
Pull request in esphome with python changes (if applicable): esphome/esphome#
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Checklist:
If user exposed functionality or configuration variables are added/changed: