Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BLE passkey authentication #2607

Merged
merged 19 commits into from
May 1, 2023

Conversation

Mat931
Copy link
Contributor

@Mat931 Mat931 commented Jan 20, 2023

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#4258

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

@Mat931 Mat931 changed the title Ble client passkey Add support for BLE passkey authentication Jan 20, 2023
@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 15ea6ea
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/644f88e9cf5862000803176d
😎 Deploy Preview https://deploy-preview-2607--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Mat931 Mat931 marked this pull request as ready for review January 27, 2023 21:59
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the full examples to the bottom of the page at least after the actions.

@Mat931 Mat931 requested a review from jesserockz May 1, 2023 09:41
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change 👍

@jesserockz jesserockz merged commit 4d8e238 into esphome:next May 1, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
@Mat931 Mat931 deleted the ble-client-passkey branch August 10, 2023 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants