Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grove TB6612FNG #2906

Merged
merged 7 commits into from
Jul 12, 2023
Merged

grove TB6612FNG #2906

merged 7 commits into from
Jul 12, 2023

Conversation

max246
Copy link
Contributor

@max246 max246 commented May 9, 2023

Description:

Pull request in esphome with YAML changes (if applicable): esphome/esphome#

Checklist:

  • [ x ] I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • [ x] Link added in /index.rst when creating new documents for new components or cookbook.

@netlify
Copy link

netlify bot commented May 9, 2023

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit ba664a9
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/64ae06acf5442500088e8e74
😎 Deploy Preview https://deploy-preview-2906--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 9, 2023
@max246
Copy link
Contributor Author

max246 commented Jul 9, 2023

Need a reviewer :/

@github-actions github-actions bot removed the stale label Jul 10, 2023
@jesserockz jesserockz merged commit f54cf2f into esphome:next Jul 12, 2023
2 checks passed
@glmnet
Copy link
Member

glmnet commented Jul 12, 2023

This is not good. Check https://next.esphome.io/#motor-components no table format here?? May be this should go into misc components?

Also the doc file is grove-tb6612fng which looks ok to me as this implements the chip with that name, but the esphome component is grove_i2c_motor. This is just wrong; no other components mismatch like this. Easiest will be to rename the doc file, but I believe naming the component as the chip is much better.

Also same image grove_tb6612fng.jpg is in two folders.

@max246
Copy link
Contributor Author

max246 commented Jul 12, 2023

This is not good. Check https://next.esphome.io/#motor-components no table format here?? May be this should go into misc components?

Also the doc file is grove-tb6612fng which looks ok to me as this implements the chip with that name, but the esphome component is grove_i2c_motor. This is just wrong; no other components mismatch like this. Easiest will be to rename the doc file, but I believe naming the component as the chip is much better.

Also same image grove_tb6612fng.jpg is in two folders.

I will open a PR to amend the naming in the main core and another one to fix the table in the doc. thank you for pointing it out.

@jesserockz jesserockz mentioned this pull request Jul 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants