New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Grove tb6612 fng #4797
Conversation
Hey there @max246, CODEOWNERS = ["@max246"] And run (message by NeedsCodeownersLabel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just a few "tips" to align better with the codebase =)
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@jesserockz could this be approved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the actions to the test yaml file too
Should be all good now |
What does this implement/fix?
I am working with this handy motor driver which can drive DC and Stepper motors : https://wiki.seeedstudio.com/Grove-I2C_Motor_Driver-TB6612FNG/
The good thing about this driver is the connectivity to be used over i2c rather than the usual hbridge and you can set the motor driver to standby to stop wasting power.
Methods implemented:
At the current state, only DC motor is implemented but the code for the stepper motor is already ready to be expose via an action. I dont currently have a stepper motor so in my case I can only test a DC motor
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2906
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: