Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tuya Climate for new esphome PR #3096

Merged
merged 8 commits into from
Mar 21, 2024

Conversation

moriahmorgan
Copy link
Contributor

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#5159

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

Update Tuya Climate to document related to esphome/esphome#5159
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 8c6a3e5
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/65fb8062e9659700082fb4dc
😎 Deploy Preview https://deploy-preview-3096--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

components/climate/tuya.rst Outdated Show resolved Hide resolved
components/climate/tuya.rst Outdated Show resolved Hide resolved
components/climate/tuya.rst Outdated Show resolved Hide resolved
moriahmorgan and others added 2 commits August 7, 2023 17:22
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@moriahmorgan
Copy link
Contributor Author

Do I need to do anything more for the documentation here?

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 25, 2023
@moriahmorgan
Copy link
Contributor Author

Sorry for letting this sit. I will attempt to update tomorrow with the request you made. I have had a very busy last few months.

@github-actions github-actions bot removed the stale label Dec 1, 2023
@moriahmorgan
Copy link
Contributor Author

Everything should be ready for a code review, let me know if anything else needs to be done.

components/climate/tuya.rst Outdated Show resolved Hide resolved
components/climate/tuya.rst Outdated Show resolved Hide resolved
components/climate/tuya.rst Outdated Show resolved Hide resolved
components/climate/tuya.rst Outdated Show resolved Hide resolved
components/climate/tuya.rst Outdated Show resolved Hide resolved
components/climate/tuya.rst Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft March 21, 2024 00:32
@esphome
Copy link

esphome bot commented Mar 21, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@kbx81 kbx81 marked this pull request as ready for review March 21, 2024 00:33
@esphome esphome bot requested a review from kbx81 March 21, 2024 00:33
@kbx81 kbx81 dismissed jesserockz’s stale review March 21, 2024 00:39

Changes made as requested

@kbx81 kbx81 merged commit 9a71004 into esphome:next Mar 21, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants