New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new modes in Tuya Climate #5159
Conversation
Added support for Fan Only Mode, Dry Mode, Swing Mode and Fan Speed Control. Also added/fixed support for entity states syncing with current operation mode.
Added support for Fan Only Mode, Dry Mode, Swing Mode and Fan Speed Control. Also added/fixed support for entity states syncing with current operation mode. This commit fixes the namespace, because I uploaded the test files to start with.
Add grouping to Preset, Swing Mode, Fan Speed and Active State. This is a breaking change.
This is now a breaking change. Added grouping to Preset, Swing Mode, Fan Speed and Active State. |
Formatting changes to be compliant with black and flake8. Also changed constants to match expected format.
Update Tuya climate documentation to align with esphome/esphome#5159
Update Tuya Climate to document related to esphome/esphome#5159
Make changes to _init_.py according to https://github.com/esphome/esphome/pull/5159/files/649b923804c05fa6ee750e824e3d7d70fadeabd9#r1278620976, https://github.com/esphome/esphome/pull/5159/files/649b923804c05fa6ee750e824e3d7d70fadeabd9#r1278621039, https://github.com/esphome/esphome/pull/5159/files/649b923804c05fa6ee750e824e3d7d70fadeabd9#r1278620904, and https://github.com/esphome/esphome/pull/5159/files/649b923804c05fa6ee750e824e3d7d70fadeabd9#r1278620549 Also put Sleep preset in its own config block to be consistent with other presets and fix logic for validate_cooling_values function to better align with existing documentation.
Requested changes reviewed and changes applied in single commit so that I could validate testing. Also put Sleep preset in its own config block to be consistent with other presets and fix logic for validate_cooling_values function to better align with existing documentation. |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
adding "this->" to some member variables in the swing_mode function.
Adding Walrus Operator in the to_code function for _init_.py similar to esphome#5181
Not sure what's causing |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Is there any chance to have this pr merged? |
I think it's just waiting on me to finish documentation. I have had a bit of a busy last few months health related and it keeps getting put on the back burner. I will attempt to finish this weekend, since @jesserockz is currently out for the rest of the week. |
I'm sorry, hope you are well now. Let me know if i can help writing the docs in some way. |
@shakin89 Docs updated, just waiting for review, approval, then merge by @jesserockz when he has time, unless there are other issues to resolve. It has been some months since I looked at the code and I don't know if there's any issues right now with merging this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5159 +/- ##
==========================================
- Coverage 53.70% 53.49% -0.22%
==========================================
Files 50 50
Lines 9408 9520 +112
Branches 1654 1684 +30
==========================================
+ Hits 5053 5093 +40
- Misses 4056 4119 +63
- Partials 299 308 +9 ☔ View full report in Codecov by Sentry. |
* Update Tuya Climate for new esphome PR Update Tuya Climate to document related to esphome/esphome#5159 * Remove Deprecated Config Block Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com> * Update tuya.rst * Restore basic device configuration sample block, will use more specific examples in the device repo * Apply suggestions from code review Copy fixes --------- Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com> Co-authored-by: H. Árkosi Róbert <robreg@zsurob.hu> Co-authored-by: Keith Burzinski <kbx81x@gmail.com>
What does this implement/fix?
Added support for Fan Only Mode, Dry Mode, Swing Mode and Fan Speed Control.
Also added/fixed support for entity states syncing with current operation mode.
Types of changes
Related issue or feature (if applicable): fixes
esphome/feature-requests#2329
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3096
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: