Skip to content

Commit

Permalink
Handle nanoseconds in config (#5695)
Browse files Browse the repository at this point in the history
  • Loading branch information
jesserockz committed Nov 8, 2023
1 parent d81bec8 commit 972598a
Show file tree
Hide file tree
Showing 4 changed files with 57 additions and 12 deletions.
21 changes: 20 additions & 1 deletion esphome/config_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
TimePeriod,
TimePeriodMicroseconds,
TimePeriodMilliseconds,
TimePeriodNanoseconds,
TimePeriodSeconds,
TimePeriodMinutes,
)
Expand Down Expand Up @@ -718,6 +719,8 @@ def time_period_str_unit(value):
raise Invalid("Expected string for time period with unit.")

unit_to_kwarg = {
"ns": "nanoseconds",
"nanoseconds": "nanoseconds",
"us": "microseconds",
"microseconds": "microseconds",
"ms": "milliseconds",
Expand All @@ -739,7 +742,10 @@ def time_period_str_unit(value):
raise Invalid(f"Expected time period with unit, got {value}")
kwarg = unit_to_kwarg[one_of(*unit_to_kwarg)(match.group(2))]

return TimePeriod(**{kwarg: float(match.group(1))})
try:
return TimePeriod(**{kwarg: float(match.group(1))})
except ValueError as e:
raise Invalid(e) from e


def time_period_in_milliseconds_(value):
Expand All @@ -749,10 +755,18 @@ def time_period_in_milliseconds_(value):


def time_period_in_microseconds_(value):
if value.nanoseconds is not None and value.nanoseconds != 0:
raise Invalid("Maximum precision is microseconds")
return TimePeriodMicroseconds(**value.as_dict())


def time_period_in_nanoseconds_(value):
return TimePeriodNanoseconds(**value.as_dict())


def time_period_in_seconds_(value):
if value.nanoseconds is not None and value.nanoseconds != 0:
raise Invalid("Maximum precision is seconds")
if value.microseconds is not None and value.microseconds != 0:
raise Invalid("Maximum precision is seconds")
if value.milliseconds is not None and value.milliseconds != 0:
Expand All @@ -761,6 +775,8 @@ def time_period_in_seconds_(value):


def time_period_in_minutes_(value):
if value.nanoseconds is not None and value.nanoseconds != 0:
raise Invalid("Maximum precision is minutes")
if value.microseconds is not None and value.microseconds != 0:
raise Invalid("Maximum precision is minutes")
if value.milliseconds is not None and value.milliseconds != 0:
Expand All @@ -787,6 +803,9 @@ def update_interval(value):
positive_time_period_microseconds = All(
positive_time_period, time_period_in_microseconds_
)
positive_time_period_nanoseconds = All(
positive_time_period, time_period_in_nanoseconds_
)
positive_not_null_time_period = All(
time_period, Range(min=TimePeriod(), min_included=False)
)
Expand Down
37 changes: 29 additions & 8 deletions esphome/core/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ def is_approximately_integer(value):
class TimePeriod:
def __init__(
self,
nanoseconds=None,
microseconds=None,
milliseconds=None,
seconds=None,
Expand Down Expand Up @@ -136,13 +137,23 @@ def __init__(

if microseconds is not None:
if not is_approximately_integer(microseconds):
raise ValueError("Maximum precision is microseconds")
frac_microseconds, microseconds = math.modf(microseconds)
nanoseconds = (nanoseconds or 0) + frac_microseconds * 1000
self.microseconds = int(round(microseconds))
else:
self.microseconds = None

if nanoseconds is not None:
if not is_approximately_integer(nanoseconds):
raise ValueError("Maximum precision is nanoseconds")
self.nanoseconds = int(round(nanoseconds))
else:
self.nanoseconds = None

def as_dict(self):
out = OrderedDict()
if self.nanoseconds is not None:
out["nanoseconds"] = self.nanoseconds
if self.microseconds is not None:
out["microseconds"] = self.microseconds
if self.milliseconds is not None:
Expand All @@ -158,6 +169,8 @@ def as_dict(self):
return out

def __str__(self):
if self.nanoseconds is not None:
return f"{self.total_nanoseconds}ns"
if self.microseconds is not None:
return f"{self.total_microseconds}us"
if self.milliseconds is not None:
Expand All @@ -173,7 +186,11 @@ def __str__(self):
return "0s"

def __repr__(self):
return f"TimePeriod<{self.total_microseconds}>"
return f"TimePeriod<{self.total_nanoseconds}ns>"

@property
def total_nanoseconds(self):
return self.total_microseconds * 1000 + (self.nanoseconds or 0)

@property
def total_microseconds(self):
Expand Down Expand Up @@ -201,35 +218,39 @@ def total_days(self):

def __eq__(self, other):
if isinstance(other, TimePeriod):
return self.total_microseconds == other.total_microseconds
return self.total_nanoseconds == other.total_nanoseconds
return NotImplemented

def __ne__(self, other):
if isinstance(other, TimePeriod):
return self.total_microseconds != other.total_microseconds
return self.total_nanoseconds != other.total_nanoseconds
return NotImplemented

def __lt__(self, other):
if isinstance(other, TimePeriod):
return self.total_microseconds < other.total_microseconds
return self.total_nanoseconds < other.total_nanoseconds
return NotImplemented

def __gt__(self, other):
if isinstance(other, TimePeriod):
return self.total_microseconds > other.total_microseconds
return self.total_nanoseconds > other.total_nanoseconds
return NotImplemented

def __le__(self, other):
if isinstance(other, TimePeriod):
return self.total_microseconds <= other.total_microseconds
return self.total_nanoseconds <= other.total_nanoseconds
return NotImplemented

def __ge__(self, other):
if isinstance(other, TimePeriod):
return self.total_microseconds >= other.total_microseconds
return self.total_nanoseconds >= other.total_nanoseconds
return NotImplemented


class TimePeriodNanoseconds(TimePeriod):
pass


class TimePeriodMicroseconds(TimePeriod):
pass

Expand Down
3 changes: 3 additions & 0 deletions esphome/cpp_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
TimePeriodMicroseconds,
TimePeriodMilliseconds,
TimePeriodMinutes,
TimePeriodNanoseconds,
TimePeriodSeconds,
)
from esphome.helpers import cpp_string_escape, indent_all_but_first_and_last
Expand Down Expand Up @@ -351,6 +352,8 @@ def safe_exp(obj: SafeExpType) -> Expression:
return IntLiteral(obj)
if isinstance(obj, float):
return FloatLiteral(obj)
if isinstance(obj, TimePeriodNanoseconds):
return IntLiteral(int(obj.total_nanoseconds))
if isinstance(obj, TimePeriodMicroseconds):
return IntLiteral(int(obj.total_microseconds))
if isinstance(obj, TimePeriodMilliseconds):
Expand Down
8 changes: 5 additions & 3 deletions tests/unit_tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,16 @@ def test_init(self, kwargs, expected):

assert actual == expected

def test_init__microseconds_with_fraction(self):
with pytest.raises(ValueError, match="Maximum precision is microseconds"):
core.TimePeriod(microseconds=1.1)
def test_init__nanoseconds_with_fraction(self):
with pytest.raises(ValueError, match="Maximum precision is nanoseconds"):
core.TimePeriod(nanoseconds=1.1)

@pytest.mark.parametrize(
"kwargs, expected",
(
({}, "0s"),
({"nanoseconds": 1}, "1ns"),
({"nanoseconds": 1.0001}, "1ns"),
({"microseconds": 1}, "1us"),
({"microseconds": 1.0001}, "1us"),
({"milliseconds": 2}, "2ms"),
Expand Down

0 comments on commit 972598a

Please sign in to comment.