Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nanoseconds in config #5695

Merged
merged 3 commits into from Nov 8, 2023
Merged

Handle nanoseconds in config #5695

merged 3 commits into from Nov 8, 2023

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

A bug found in the esp32_rmt_led_strip code led to finding that the values set in config should be nanoseconds not microseconds which ESPHome did not yet support.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz requested a review from a team as a code owner November 8, 2023 07:38
@probot-esphome probot-esphome bot added the core label Nov 8, 2023
@jesserockz jesserockz added this to the 2023.11.0b2 milestone Nov 8, 2023
@jesserockz jesserockz merged commit 972598a into dev Nov 8, 2023
45 checks passed
@jesserockz jesserockz deleted the jesserockz-2023-399 branch November 8, 2023 08:34
@jesserockz jesserockz mentioned this pull request Nov 9, 2023
jesserockz added a commit that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants