Add 7.5inch v2 waveshare #1077
Merged
Add 7.5inch v2 waveshare #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ~() to invert the bytecode and make the screen look black text on white background
|
Removed invisible whitespaces |
OttoWinter
reviewed
Jul 15, 2020
| @@ -31,6 +32,7 @@ | |||
| '4.20in': ('b', WaveshareEPaper4P2In), | |||
| '5.83in': ('b', WaveshareEPaper5P8In), | |||
| '7.50in': ('b', WaveshareEPaper7P5In), | |||
| '7.50inV2': ('b', WaveshareEPaper7P5InV2), | |||
There was a problem hiding this comment.
This doesn't work because V is uppercase, and the config validator normalizes everything to lowercase before checking the model (see line 51).
Also: please test your changes before you create a PR
OttoWinter
added
integration: waveshare_epaper
and removed
component: display.waveshare_epaper
labels
rspaargaren
pushed a commit
to rspaargaren/esphome
that referenced
this pull request
Jul 30, 2020
* Added 7.5inchV2 * Added 7.5inV2 * Added 7.5inch_V2 * fixed Display function * Inverted bytecode Added ~() to invert the bytecode and make the screen look black text on white background * Hoping to keep Travis happy with blank lines * more travis hacking * travis happy? * wow * gfhj
rspaargaren
pushed a commit
to rspaargaren/esphome
that referenced
this pull request
Jul 30, 2020
sashao
pushed a commit
to sashao/esphome
that referenced
this pull request
Oct 23, 2020
* Added 7.5inchV2 * Added 7.5inV2 * Added 7.5inch_V2 * fixed Display function * Inverted bytecode Added ~() to invert the bytecode and make the screen look black text on white background * Hoping to keep Travis happy with blank lines * more travis hacking * travis happy? * wow * gfhj
sashao
pushed a commit
to sashao/esphome
that referenced
this pull request
Oct 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes esphome/feature-requests#753
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#675
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: