Fix dashboard logout button and py3.8 removed hmac.new digestmod #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might also fix esphome/issues#1277 |
No reason to use HMAC here, as authenticity is not an issue
pkuehne
reviewed
Jul 17, 2020
rspaargaren
pushed a commit
to rspaargaren/esphome
that referenced
this pull request
Jul 30, 2020
…home#1156) * Fix dashboard logout button and py3.8 removed hmac.new digestmod * Just use SHA256 No reason to use HMAC here, as authenticity is not an issue * Wrong branch * Clenaup
sashao
pushed a commit
to sashao/esphome
that referenced
this pull request
Oct 23, 2020
…home#1156) * Fix dashboard logout button and py3.8 removed hmac.new digestmod * Just use SHA256 No reason to use HMAC here, as authenticity is not an issue * Wrong branch * Clenaup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes two things:
hmac.newbehavior. It doesn't set the HMAC digest mode anymore (previously it wasmd5which of course is not so good). -> Switch to using HMAC-SHA256.Related issue (if applicable): fixes esphome/issues#1277
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: