Add support for PMSA003i - #1501
Merged
Merged
Conversation
glmnet
requested changes
Mar 14, 2021
glmnet
left a comment
glmnet
left a comment
Member
There was a problem hiding this comment.
Please rebase as this would fail marging on dev.
Thanks
OttoWinter
reviewed
Aug 3, 2021
OttoWinter
left a comment
OttoWinter
left a comment
Member
There was a problem hiding this comment.
Thanks for this contribution! Code looks good to me. Just one minor thing about the struct, can you have a look at it
Co-authored-by: Otto Winter <otto@otto-winter.com>
OttoWinter
approved these changes
Aug 10, 2021
This was referenced Aug 11, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for the PMSA003i sensor, which is an i2c version of similar particulate sensors from Plantower.
Original implementation here https://github.com/sjtrny/pmsa003i
Pull request in esphome-docs with documentation (if applicable):
esphome/esphome.io#973
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: