Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PMSA003i #1501

Merged
merged 22 commits into from
Aug 10, 2021
Merged

Add support for PMSA003i #1501

merged 22 commits into from
Aug 10, 2021

Conversation

sjtrny
Copy link
Contributor

@sjtrny sjtrny commented Jan 30, 2021 •
edited
Loading

Description:

Adds support for the PMSA003i sensor, which is an i2c version of similar particulate sensors from Plantower.

Original implementation here https://github.com/sjtrny/pmsa003i

Pull request in esphome-docs with documentation (if applicable):

esphome/esphome-docs#973

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@sjtrny sjtrny marked this pull request as ready for review January 30, 2021 13:03
@sjtrny sjtrny mentioned this pull request Feb 2, 2021
Merged
2 tasks
glmnet
glmnet requested changes Mar 14, 2021
View reviewed changes
Copy link
Member

@glmnet glmnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase as this would fail marging on dev.

Thanks

esphome/components/pmsa003i/pmsa003i.h Outdated Show resolved Hide resolved
esphome/components/pmsa003i/sensor.py Outdated Show resolved Hide resolved
esphome/components/pmsa003i/pmsa003i.cpp Outdated Show resolved Hide resolved
esphome/components/pmsa003i/pmsa003i.cpp Outdated Show resolved Hide resolved
@sjtrny sjtrny requested a review from glmnet March 16, 2021 11:05
@jesserockz jesserockz added this to In Review in ESPHome Dev May 19, 2021
OttoWinter
OttoWinter reviewed Aug 3, 2021
View reviewed changes
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Code looks good to me. Just one minor thing about the struct, can you have a look at it

esphome/components/pmsa003i/pmsa003i.h Outdated Show resolved Hide resolved
@sjtrny @OttoWinter
Update esphome/components/pmsa003i/pmsa003i.h
c8971bb 
Co-authored-by: Otto Winter <otto@otto-winter.com>
@OttoWinter OttoWinter merged commit 6a2f0f5 into esphome:dev Aug 10, 2021
ESPHome Dev automation moved this from In Review to Done Aug 10, 2021
This was referenced Aug 11, 2021
Merged
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
ESPHome Dev automation moved this from Done to In Review Sep 23, 2023
ESPHome Dev automation moved this from In Review to Reviewer Approved Sep 23, 2023
ESPHome Dev automation moved this from Reviewer Approved to Done Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OttoWinter OttoWinter OttoWinter approved these changes

@glmnet glmnet Awaiting requested review from glmnet

Assignees
No one assigned
Labels
has-tests integration: pmsa003i new-integration
Projects
ESPHome Dev
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjtrny @glmnet @OttoWinter