Change COLOR_ON to be 255 values instead of 1 #1594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Changing the COLOR_ON rgb values for greyscale/colour displays
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Explain your changes
COLOR_ON
andCOLOR_OFF
were good when it was only black/white displays, but with color and greyscale displays, theCOLOR_ON
is only 1/255 color, and could easily be changed to be white like this PR does without breaking uses of it that rely on it.Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: