Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change COLOR_ON to be 255 values instead of 1 #1594

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Change COLOR_ON to be 255 values instead of 1 #1594

merged 1 commit into from
Mar 14, 2021

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Mar 8, 2021

What does this implement/fix?

Changing the COLOR_ON rgb values for greyscale/colour displays

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (this will require users to update their yaml configuraiton files to keep working)

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP8266
  • Windows
  • Mac OS
  • Linux

Example entry for config.yaml:

# Example config.yaml

Explain your changes

COLOR_ON and COLOR_OFF were good when it was only black/white displays, but with color and greyscale displays, the COLOR_ON is only 1/255 color, and could easily be changed to be white like this PR does without breaking uses of it that rely on it.

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@kbx81
Copy link
Member

kbx81 commented Mar 8, 2021

Yeahhhh...I agree, this is how it should be now. I feel like I fixed this in one or two other places but this is really how/where it should be done.

@glmnet glmnet merged commit 848a5f1 into dev Mar 14, 2021
@glmnet glmnet deleted the display/color-on branch March 14, 2021 00:27
taquitos pushed a commit to taquitos/esphome that referenced this pull request Mar 14, 2021
This was referenced Mar 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants