Drop 128x160 ESP-32 camera resolution #1813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Since the addition of OV5640 support in the ESP-32 camera driver in March 2020, it no longer provides the FRAMESIZE_QQVGA2 type. This was imported in Arduino ESP32 core 1.0.5, so compilation was broken from that version onwards.
Drop the support for this resolution, as this specific resolution does not seem to be useful enough for it to be worthwhile to make it conditionally available depending on the used Arduino version (which is further complicated by the fact that Arduino doesn't provide a numeric version define).
Types of changes
Technically this is a breaking change for users using this resolution, but I don't think we should bother to do anything about that beyond a changelog entry.
Related issue or feature (if applicable): fixes esphome/issues#1884
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:N/A
Explain your changes
It fixes compilation.
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: