Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 128x160 ESP-32 camera resolution #1813

Merged
merged 2 commits into from
May 31, 2021

Conversation

oxan
Copy link
Member

@oxan oxan commented May 21, 2021

What does this implement/fix?

Since the addition of OV5640 support in the ESP-32 camera driver in March 2020, it no longer provides the FRAMESIZE_QQVGA2 type. This was imported in Arduino ESP32 core 1.0.5, so compilation was broken from that version onwards.

Drop the support for this resolution, as this specific resolution does not seem to be useful enough for it to be worthwhile to make it conditionally available depending on the used Arduino version (which is further complicated by the fact that Arduino doesn't provide a numeric version define).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (this will require users to update their yaml configuration files to keep working)

Technically this is a breaking change for users using this resolution, but I don't think we should bother to do anything about that beyond a changelog entry.

Related issue or feature (if applicable): fixes esphome/issues#1884

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP8266
  • Windows
  • Mac OS
  • Linux

Example entry for config.yaml:

N/A

Explain your changes

It fixes compilation.

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Since the addition of OV5640 support in the ESP-32 camera driver in
March 2020, it no longer provides the FRAMESIZE_QQVGA2 type. This was
imported in Arduino ESP32 core 1.0.5, so compilation was broken from
that version onwards.

Drop the support for this resolution, as this specific resolution does
not seem to be useful enough for it to be worthwhile to make it
conditionally available depending on the used Arduino version (which is
further complicated by the fact that Arduino doesn't provide a numeric
version define).
This ensures it gets compile-tested in CI.
@oxan
Copy link
Member Author

oxan commented May 22, 2021

I also added the ESP-32 camera to one of the test YAML files, so that it'll at least get compile tested in CI from now on in the hopes that'll catch similar breakage faster from now on :)

Copy link
Contributor

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually fixes compiling the Camera component with Arduino SDK 1.0.6.

@jesserockz jesserockz merged commit 25af5ab into esphome:dev May 31, 2021
@oxan oxan deleted the fix-esp32-compilation branch May 31, 2021 11:39
@oxan
Copy link
Member Author

oxan commented May 31, 2021

This is esphome/esphome-docs#1192 btw, I see I forgot to fill in the PR number.

This was referenced Jun 9, 2021
This was referenced Jun 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

espcam fails to compile with espressif@3.1.0
3 participants