New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deassert_rts_dtr option to force RTS/DTR low when using miniterm #2089
Conversation
By default RTS/DTR seem to be True (-> 0 since low active). Most ESP32 boards have a pair of transistors to keep Reset/strapping GPIO as-is when both RTS/DTR are either True _or_ False. See: https://raw.githubusercontent.com/nodemcu/nodemcu-devkit/master/Documents/NODEMCU_DEVKIT_SCH_BIG.png If RTS/DTR are connected to Reset/strapping GPIO directly we'd prefer to have RTS/DTR False (-> 1 since low active). In theory, we could set it to False always, since the above mentioned logic makes sure nothing happens if both signals are False. However, on some platforms (e.g. Linux) setting them to False leads to toggling when opening which causes a reset. This introduces a new config "low_rts_dtr" which allows to set the signals low if required by the board.
Hey there @esphome/core, mind taking a look at this pull request as its been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Docs need to be updated though
Now that I write the documentation, I don't like |
Works for me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for my C3
What does this implement/fix?
By default RTS/DTR seem to be True (-> 0 since low active). Most ESP32
boards have a pair of transistors to keep Reset/strapping GPIO as-is
when both RTS/DTR are either True or False.
See: https://raw.githubusercontent.com/nodemcu/nodemcu-devkit/master/Documents/NODEMCU_DEVKIT_SCH_BIG.png
If RTS/DTR are connected to Reset/strapping GPIO directly we'd prefer to have
RTS/DTR False (-> 1 since low active). In theory, we could set it to False
always, since the above mentioned logic makes sure nothing happens if both
signals are False.
However, on some platforms (e.g. Linux) setting them to False leads to toggling
when opening which causes a reset.
This introduces a new config "low_rts_dtr" which allows to set the
signals low if required by the board.
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#1382
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#1348
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: