Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deassert_rts_dtr option to force RTS/DTR low when using miniterm #2089

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Add deassert_rts_dtr option to force RTS/DTR low when using miniterm #2089

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67a71a
Add low_rts_dtr option to force RTS/DTR low when using miniterm
agners Jul 28, 2021
9aa6156
Use deassert_rts_dtr instead of low_rts_dtr
agners Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion esphome/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
CONF_BAUD_RATE,
CONF_BROKER,
CONF_LOGGER,
CONF_LOW_RTS_DTR,
CONF_OTA,
CONF_PASSWORD,
CONF_PORT,
Expand Down Expand Up @@ -99,10 +100,21 @@ def run_miniterm(config, port):
baud_rate = config["logger"][CONF_BAUD_RATE]
if baud_rate == 0:
_LOGGER.info("UART logging is disabled (baud_rate=0). Not starting UART logs.")
return
_LOGGER.info("Starting log output from %s with baud rate %s", port, baud_rate)

backtrace_state = False
with serial.Serial(port, baudrate=baud_rate) as ser:
ser = serial.Serial()
ser.baudrate = baud_rate
ser.port = port

# We can't set to False by default since it leads to toggling and hence
# ESP32 resets on some platforms.
if config["logger"][CONF_LOW_RTS_DTR]:
ser.dtr = False
ser.rts = False

with ser:
while True:
try:
raw = ser.readline()
Expand Down
2 changes: 2 additions & 0 deletions esphome/components/logger/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
CONF_ID,
CONF_LEVEL,
CONF_LOGS,
CONF_LOW_RTS_DTR,
CONF_ON_MESSAGE,
CONF_TAG,
CONF_TRIGGER_ID,
Expand Down Expand Up @@ -104,6 +105,7 @@ def validate_local_no_higher_than_global(value):
cv.GenerateID(): cv.declare_id(Logger),
cv.Optional(CONF_BAUD_RATE, default=115200): cv.positive_int,
cv.Optional(CONF_TX_BUFFER_SIZE, default=512): cv.validate_bytes,
cv.Optional(CONF_LOW_RTS_DTR, default=False): cv.boolean,
cv.Optional(CONF_HARDWARE_UART, default="UART0"): uart_selection,
cv.Optional(CONF_LEVEL, default="DEBUG"): is_log_level,
cv.Optional(CONF_LOGS, default={}): cv.Schema(
Expand Down
1 change: 1 addition & 0 deletions esphome/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@
CONF_LOGS = "logs"
CONF_LONGITUDE = "longitude"
CONF_LOW = "low"
CONF_LOW_RTS_DTR = "low_rts_dtr"
CONF_LOW_VOLTAGE_REFERENCE = "low_voltage_reference"
CONF_MAC_ADDRESS = "mac_address"
CONF_MAINS_FILTER = "mains_filter"
Expand Down