Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Airthing Wave Mini #2440

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Conversation

ncareau
Copy link
Contributor

@ncareau ncareau commented Oct 4, 2021

What does this implement/fix?

Add support for the Airthing Wave Mini BLE device.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#1505

Test Environment

  • ESP32
  • ESP8266

Example entry for config.yaml:

Sensors:

  - platform: airthings_wave_mini
    ble_client_id: airthingsmini
    update_interval: 5min # default
    temperature:
      name: "WaveMini Temperature"
    humidity:
      name: "WaveMini Humidity"
    pressure:
      name: "WaveMini Pressure"
    tvoc:
      name: "WaveMini VOC"   

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Oct 4, 2021

Hey there @ncareau,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@ncareau"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@ncareau
Copy link
Contributor Author

ncareau commented Oct 4, 2021

Hello, I've made this PR in particular for the event hacktoberfest by digital ocean : https://hacktoberfest.digitalocean.com. I would really appreciate if you could add the label hacktoberfest-accepted to this PR (or add a label hacktoberfest to the project) in order to make my PR count towards my goal. Thank you.

@jesserockz
Copy link
Member

Hello, I've made this PR in particular for the event hacktoberfest by digital ocean : hacktoberfest.digitalocean.com. I would really appreciate if you could add the label hacktoberfest-accepted to this PR (or add a label hacktoberfest to the project) in order to make my PR count towards my goal. Thank you.

ESPHome is already participating, and PRs will count once approved or merged =)
No need for extra labels

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesserockz jesserockz merged commit 8773676 into esphome:dev Oct 4, 2021
@ncareau
Copy link
Contributor Author

ncareau commented Oct 5, 2021

Thanks a lot.

@alexiri alexiri mentioned this pull request Oct 5, 2021
9 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants