Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few esp32_ble_server/improv fixes #2562

Merged
merged 4 commits into from
Oct 20, 2021
Merged

A few esp32_ble_server/improv fixes #2562

merged 4 commits into from
Oct 20, 2021

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

  • Fix esp32_ble_server setup_priority
    This was the same as esp32_improv and causing issues
  • Utilize shared_ptr in ble_server for services

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz merged commit e4d17e0 into dev Oct 20, 2021
@jesserockz jesserockz deleted the ble-server-fixes branch October 20, 2021 17:45
jesserockz added a commit that referenced this pull request Oct 20, 2021
@jesserockz jesserockz mentioned this pull request Oct 20, 2021
@jesserockz jesserockz mentioned this pull request Oct 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant