Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation using subprocesses #2834

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Fix compilation using subprocesses #2834

merged 2 commits into from
Dec 1, 2021

Conversation

oxan
Copy link
Member

@oxan oxan commented Nov 29, 2021

What does this implement/fix?

Quick description and explanation of changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#2763.

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@oxan oxan merged commit fbe1bca into esphome:dev Dec 1, 2021
@oxan oxan deleted the misc/subprocess branch December 1, 2021 16:37
@jesserockz jesserockz mentioned this pull request Dec 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Building images with ESPHOME_USE_SUBPROCESS fails since 2021.10.0b4
2 participants