Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modbus: fix response parsing error for coil write #2986

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

martgras
Copy link
Contributor

@martgras martgras commented Jan 3, 2022

What does this implement/fix?

The response to the Force Multiple Coils (function code 0xF) command is not parsed correctly and causes CRC errors

Quick description and explanation of changes
correct response length calculation for function code 0xF

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

The response to Force Multiple Coils (function code 0xF) command is not parsed correctly and causes CRC errors
@oxan oxan merged commit 45ebe51 into esphome:dev Jan 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2022
@martgras martgras deleted the patch-6 branch January 10, 2022 08:07
@jesserockz jesserockz removed this from the 2021.12.4 milestone Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants