Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delonghi Penguino PAC W120HP ir support #3124

Merged
merged 14 commits into from
May 10, 2022

Conversation

grob6000
Copy link
Contributor

@grob6000 grob6000 commented Jan 27, 2022

What does this implement/fix?

Add support for a slightly odd delonghi infrared protocol. Used the daikin module as a guide.
I've done this mostly just for myself; so I haven't got around to checking whether this is the current best practice way of adding support for a device, or documenting properly; if this has any support for inclusion, after any modifications I'm happy to fix the docs etc. then.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

esphome/esphome-docs#1953

Related issue or feature (if applicable):

N/A - no issue raised

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml
i2c:
  sda: 4
  scl: 5
  scan: true
  id: bus_a

sensor:
  - platform: sht3xd
    temperature:
      name: "Penguino Temperature"
      id: tempsensor
    humidity:
      name: "Penguino Humidity"
      id: humiditysensor
    update_interval: 60s

climate:
  - platform: delonghi
    name: "Penguino"
    sensor: tempsensor
    receiver_id: receiver1
    
remote_receiver:
  - id: receiver1
    pin:
      number: 14
      inverted: true
      mode: INPUT_PULLUP
    tolerance: 55%
    dump: all

remote_transmitter:
  - id: transmitter1
    pin: 15
    carrier_duty_percent: 50%

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @grob6000,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@grob6000"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

grob6000 referenced this pull request in esphome/esphome-docs Jan 28, 2022
Documentation to accompany #3124
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Please additionally:

  1. Add a really simple entry in the tests/ folder (it's just there to test if the codegen produces compilable output)
  2. Add the docs for the delonghi component.

Thanks!

@grob6000
Copy link
Contributor Author

@jesserockz
Copy link
Member

Please open a PR for the docs, just making a commit in a fork is not enough

grob6000 added a commit to grob6000/esphome-docs that referenced this pull request Mar 7, 2022
@grob6000
Copy link
Contributor Author

grob6000 commented Mar 7, 2022

Apologies. See here:
esphome/esphome-docs#1953

@grob6000
Copy link
Contributor Author

Refershed the docs PR; should be GTG now.

@jesserockz jesserockz merged commit 4e1f651 into esphome:dev May 10, 2022
@jesserockz jesserockz mentioned this pull request May 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants