-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delonghi Penguino PAC W120HP ir support #3124
Conversation
Hey there @grob6000, CODEOWNERS = ["@grob6000"] And run (message by NeedsCodeownersLabel) |
Documentation to accompany #3124
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Please additionally:
- Add a really simple entry in the
tests/
folder (it's just there to test if the codegen produces compilable output) - Add the docs for the delonghi component.
Thanks!
|
Please open a PR for the docs, just making a commit in a fork is not enough |
Apologies. See here: |
Refershed the docs PR; should be GTG now. |
What does this implement/fix?
Add support for a slightly odd delonghi infrared protocol. Used the daikin module as a guide.
I've done this mostly just for myself; so I haven't got around to checking whether this is the current best practice way of adding support for a device, or documenting properly; if this has any support for inclusion, after any modifications I'm happy to fix the docs etc. then.
Types of changes
esphome/esphome-docs#1953
Related issue or feature (if applicable):
N/A - no issue raised
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: