Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shelly dimmer: Use unique_ptr to handle the lifetime of stm32_t #3400

Merged
merged 6 commits into from
May 11, 2022

Conversation

edge90
Copy link
Contributor

@edge90 edge90 commented Apr 18, 2022

What does this implement/fix?

Automatic lifetime handling of stm32_init (stm32_t) via unique_ptr.

Quick description and explanation of changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @rnauber, mind taking a look at this pull request as it has been labeled with an integration (shelly_dimmer) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@martgras martgras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Only 2 minor format suggestions

esphome/components/shelly_dimmer/stm32flash.cpp Outdated Show resolved Hide resolved
esphome/components/shelly_dimmer/stm32flash.cpp Outdated Show resolved Hide resolved
Co-authored-by: Martin <25747549+martgras@users.noreply.github.com>
@jesserockz jesserockz added this to the 2022.5.0b2 milestone May 11, 2022
@jesserockz jesserockz merged commit c2aaae4 into esphome:dev May 11, 2022
jesserockz added a commit that referenced this pull request May 12, 2022
Co-authored-by: Martin <25747549+martgras@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@jesserockz jesserockz mentioned this pull request May 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants