Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the mute pin if configured #3568

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Setup the mute pin if configured #3568

merged 2 commits into from
Jun 17, 2022

Conversation

jesserockz
Copy link
Member

What does this implement/fix?

Quick description and explanation of changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@Jason-nz
Copy link

Confirmed this works on the Muse proto using

external_components:
  - source: github://pr#3568
    components: [i2s_audio]
    refresh: 0s

Without this PR there is no sound after a power cycle

@jesserockz jesserockz marked this pull request as ready for review June 16, 2022 10:34
@jesserockz jesserockz added this to the 2022.6.1 milestone Jun 16, 2022
@jesserockz
Copy link
Member Author

Thanks for confirming @Jason-nz

@jesserockz jesserockz merged commit 01bfafc into dev Jun 17, 2022
@jesserockz jesserockz deleted the jesserockz-2022-208 branch June 17, 2022 01:30
jesserockz added a commit that referenced this pull request Jun 18, 2022
@jesserockz jesserockz mentioned this pull request Jun 18, 2022
@renaiku
Copy link

renaiku commented Jun 18, 2022

@Jason-nz I updated to 2022.6.1 and I still have no sound outputting from the Muse proto (onboard speaker) with the folllowing config in esphome:

substitutions:
  name: raspiaudio-muse-proto-xxxxxx
  friendly_name: "RaspiAudio Muse Proto XXXXXX"
  wifi_ap_password: ""

esphome:
  name: "${name}"
  name_add_mac_suffix: false

esp32:
  board: esp-wrover-kit
  framework:
    type: arduino

logger:
api:
ota:

dashboard_import:
  package_import_url: github://esphome/media-players/raspiaudio-muse-proto.yaml@main

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password

captive_portal:

improv_serial:

media_player:
  - platform: i2s_audio
    id: media_out
    name: ${friendly_name}
    dac_type: external
    i2s_lrclk_pin: GPIO25
    i2s_dout_pin: GPIO26
    i2s_bclk_pin: GPIO5
    mode: mono
    mute_pin: 
      number: GPIO21
      inverted: true

binary_sensor:
  - platform: gpio
    pin:
      number: GPIO0
      inverted: true
    name: ${friendly_name} Button
    on_click:
      - media_player.toggle: media_out

light:
  - platform: fastled_clockless
    name: ${friendly_name}
    pin: GPIO22
    chipset: SK6812
    num_leds: 1
    rgb_order: grb

Does your proto onboard speaker emit sound ? (I can hear the speaker emiting a small noise at volume 0 like every speaker "skrch skrch") or do you use an external speaker ?

@Jason-nz
Copy link

Jason-nz commented Jun 18, 2022

I have 2, one arrived without the onboard speaker working, the other works as expected.
Have you tried an external speaker?

From what I can tell, the onboard speaker is hard wired and can only be disabled by cutting a trace on the back. So if you have sound with an external speaker then you might have a faulty onboard speaker.

Please reply on discord https://discord.gg/KhAMKrd

@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants