Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uuid lookups from BLE read/write/notify characteristics #4102

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 27, 2022

What does this implement/fix?

Prework to reduce memory pressure

Since the client is sending a specific handle they must already have the service and char data. We want to be able to release the memory used for the char/services list in a future PR, but to do that we need to remove some checks in places where we would end up re-parsing the list again. The end goal is to be able to get to this commit where we can release the char memory after sending the service list: bdraco@581d4de

See https://github.com/esphome/esphome/pull/4063/files#r1033010216 and #4063 (comment) as the motivation for this

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Since the client is sending a specific handle they must
already have the service and char data. We want to be
able to release the memory used for the char/services
list in a future PR, but to do that we need to remove
some checks in places where we would end up reparsing
the list again.

See https://github.com/esphome/esphome/pull/4063/files#r1033010216
@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (bluetooth_proxy) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit ccef7c3 into esphome:dev Nov 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants