Remove uuid lookups from BLE read/write/notify characteristics #4102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Prework to reduce memory pressure
Since the client is sending a specific handle they must already have the service and char data. We want to be able to release the memory used for the char/services list in a future PR, but to do that we need to remove some checks in places where we would end up re-parsing the list again. The end goal is to be able to get to this commit where we can release the char memory after sending the service list: bdraco@581d4de
See https://github.com/esphome/esphome/pull/4063/files#r1033010216 and #4063 (comment) as the motivation for this
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: