Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused manifest handler #4169

Merged
merged 2 commits into from Feb 9, 2023
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Dec 10, 2022

What does this implement/fix?

Remove a dashboard handler to generate manifest.json that is no longer used.

This PR requires the dashboard to be updated. Marking as draft until it is.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿

@jesserockz jesserockz marked this pull request as ready for review February 9, 2023 00:25
@jesserockz jesserockz merged commit d20d494 into dev Feb 9, 2023
@jesserockz jesserockz deleted the remove-manifest-dashboard-handler branch February 9, 2023 00:42
@jesserockz jesserockz mentioned this pull request Feb 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants