Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused manifest handler #4169

Merged
merged 2 commits into from Feb 9, 2023
Merged

Remove unused manifest handler #4169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81d9b01
Remove unused manifest handler
balloob Dec 10, 2022
df51a9f
Merge branch 'dev' into remove-manifest-dashboard-handler
jesserockz Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 0 additions & 33 deletions esphome/dashboard/dashboard.py
View file
Open in desktop
Expand Up @@ -540,38 +540,6 @@ def get(self, configuration=None):
self.finish()


class ManifestRequestHandler(BaseHandler):
@authenticated
@bind_config
def get(self, configuration=None):
args = ["esphome", "idedata", settings.rel_path(configuration)]
rc, stdout, _ = run_system_command(*args)

if rc != 0:
self.send_error(404 if rc == 2 else 500)
return

idedata = platformio_api.IDEData(json.loads(stdout))

firmware_offset = "0x10000" if idedata.extra_flash_images else "0x0"
flash_images = [
{
"path": f"./download.bin?configuration={configuration}&type=firmware.bin",
"offset": firmware_offset,
}
] + [
{
"path": f"./download.bin?configuration={configuration}&type={os.path.basename(image.path)}",
"offset": image.offset,
}
for image in idedata.extra_flash_images
]

self.set_header("Content-Type", "application/json")
self.write(json.dumps(flash_images))
self.finish()


def _list_dashboard_entries():
files = settings.list_yaml_files()
return [DashboardEntry(file) for file in files]
Expand Down Expand Up @@ -1149,7 +1117,6 @@ def set_extra_headers(self, path):
(f"{rel}info", InfoRequestHandler),
(f"{rel}edit", EditRequestHandler),
(f"{rel}download.bin", DownloadBinaryRequestHandler),
(f"{rel}manifest.json", ManifestRequestHandler),
(f"{rel}serial-ports", SerialPortRequestHandler),
(f"{rel}ping", PingRequestHandler),
(f"{rel}delete", DeleteRequestHandler),
Expand Down