Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure mtu is set for cached v3 connections #4321

Closed
wants to merge 4 commits into from
Closed

Ensure mtu is set for cached v3 connections #4321

wants to merge 4 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 20, 2023

What does this implement/fix?

fixes #4041
fixes #3951

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

bdraco added a commit to bdraco/esphome that referenced this pull request Jan 20, 2023
@bdraco
Always sent the MTU request for BLE v3 cached connections
f832322 
alternate to esphome#4321

fixes esphome#4041
fixes esphome#3951
@bdraco bdraco mentioned this pull request Jan 20, 2023
Merged
11 tasks
@bdraco bdraco closed this Jan 20, 2023
jesserockz pushed a commit that referenced this pull request Jan 20, 2023
@bdraco
Always send the MTU request for BLE v3 cached connections (#4322)
615d591 
closes #4321
fixes esphome/issues#4041
fixes esphome/issues#3951
jesserockz pushed a commit that referenced this pull request Jan 20, 2023
@bdraco @jesserockz
Always send the MTU request for BLE v3 cached connections (#4322)
00f2655 
closes #4321
fixes esphome/issues#4041
fixes esphome/issues#3951
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz Awaiting requested review from jesserockz jesserockz will be requested when the pull request is marked ready for review jesserockz is a code owner

Assignees
No one assigned
Labels
integration: bluetooth_proxy integration: esp32_ble_client small-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bdraco