Fix race condition in web_server scheduler on ESP32 #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszduda23
force-pushed
the
web
branch
3 times, most recently
from
9fce759
to
83dcf9f
Compare
jesserockz
reviewed
Oct 26, 2022
|
Is this an issue specific to ESP32 and not applicable to ESP8266? |
ESP8266 uses different library ottowinter/ESPAsyncTCP-esphome. I took quick look and cannot see any task there. @OttoWinter are you able to confirm that? I have no ESP8266 to test. |
jesserockz
approved these changes
Dec 22, 2022
jesserockz
changed the title
bdraco
added a commit
to bdraco/esphome
that referenced
this pull request
Jan 20, 2023
alternate to esphome#4321 fixes esphome#4041 fixes esphome#3951
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Race condition in scheduler
Web component schedule things from async_tcp thread which leads to race condition.
It puts things to queue and schedule them from main thread.
Types of changes
Related issue or feature (if applicable): fixes
esphome/issues#2916
esphome/issues#2632
#3943
#3917
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: