Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS3000 sensor #4502

Merged
merged 14 commits into from
Mar 7, 2023
Merged

FS3000 sensor #4502

merged 14 commits into from
Mar 7, 2023

Conversation

kahrendt
Copy link
Contributor

@kahrendt kahrendt commented Mar 3, 2023

What does this implement/fix?

This pull request adds support for the FS3000 Air Velocity Sensor. It includes support for the two available models, 1005 and 1015.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes (not applicable)

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2715

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

sensor:
  - platform: fs3000
    name: "Air Velocity"
    model: 1005
    update_interval: 60s

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Mar 3, 2023

Hey there @kahrendt,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@kahrendt"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@kahrendt kahrendt marked this pull request as ready for review March 3, 2023 15:06
@SeByDocKy
Copy link
Contributor

Very interesting sensor.... and thanks for the ESPhome integration.... I may use it in a big project

esphome/components/fs3000/sensor.py Outdated Show resolved Hide resolved
esphome/components/fs3000/sensor.py Outdated Show resolved Hide resolved
esphome/components/fs3000/sensor.py Outdated Show resolved Hide resolved
esphome/components/fs3000/fs3000.cpp Outdated Show resolved Hide resolved
esphome/components/fs3000/fs3000.h Outdated Show resolved Hide resolved
esphome/components/fs3000/fs3000.cpp Outdated Show resolved Hide resolved
esphome/components/fs3000/fs3000.cpp Outdated Show resolved Hide resolved
kahrendt and others added 5 commits March 6, 2023 07:34
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
- removed unnecessary default for FS3000Model
- use "this->" before any sensor update

Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@kahrendt
Copy link
Contributor Author

kahrendt commented Mar 6, 2023

Thank you for taking the time to review my pull request! This is all fairly new to me, and I appreciate your help. I made the requested changes, including the in-depth setting up code for each module into the setup() function, as well as fixed the sensor.py to remove the unnecessary components.

@kahrendt kahrendt requested a review from jesserockz March 7, 2023 01:34
@jesserockz jesserockz added this pull request to the merge queue Mar 7, 2023
Merged via the queue into esphome:dev with commit 6ecf4ec Mar 7, 2023
@kahrendt kahrendt deleted the fs3000-sensor branch March 7, 2023 13:10
@jesserockz jesserockz mentioned this pull request Mar 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants