Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote receiver improvements #4642

Merged
merged 38 commits into from
May 2, 2024

Conversation

Mat931
Copy link
Contributor

@Mat931 Mat931 commented Apr 1, 2023

What does this implement/fix?

  • Allow setting the tolerance in microseconds (Required for some protocols)
  • ESP32: Add a software-based glitch filter (Reason: The filter of the RMT peripheral doesn't filter out all glitches)
  • ESP32: Prevent overflow of filter_ticks_thresh and idle_threshold
  • ESP32: Allow changing the clock divider
  • Change filter to uint32_t (see increase size filter range #4244)
  • Add more Config Validation

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#3537, fixes esphome/issues#4068, fixes esphome/issues#5534

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2797

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml

external_components:
  - source: github://pr#4642
    components: [remote_base, remote_receiver]
    refresh: always

remote_receiver:
  pin: GPIO25
  filter: 8us
  tolerance: 15us
  idle: 1500us
  clock_divider: 160

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@nagyrobi nagyrobi added the not-stale Won't go stale label Jul 6, 2023
esphome/components/remote_base/remote_base.h Outdated Show resolved Hide resolved
esphome/components/remote_base/remote_base.h Outdated Show resolved Hide resolved
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
jesserockz
jesserockz previously approved these changes Dec 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.43%. Comparing base (4d8b5ed) to head (12fbbbf).
Report is 390 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4642      +/-   ##
==========================================
- Coverage   53.70%   53.43%   -0.28%     
==========================================
  Files          50       50              
  Lines        9408     9538     +130     
  Branches     1654     1685      +31     
==========================================
+ Hits         5053     5097      +44     
- Misses       4056     4130      +74     
- Partials      299      311      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esphome esphome bot marked this pull request as draft April 16, 2024 19:34
@esphome
Copy link

esphome bot commented Apr 16, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Mat931 Mat931 marked this pull request as ready for review April 17, 2024 00:42
@esphome esphome bot requested a review from jesserockz April 17, 2024 00:42
@dgomes
Copy link

dgomes commented May 1, 2024

can confirm this code works properly :)

@jesserockz jesserockz merged commit 1b9a30e into esphome:dev May 2, 2024
77 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants