-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote receiver improvements #4642
Merged
Merged
+125
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This was referenced Apr 14, 2023
jesserockz
requested changes
Dec 20, 2023
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
kbx81
reviewed
Dec 20, 2023
jesserockz
previously approved these changes
Dec 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4642 +/- ##
==========================================
- Coverage 53.70% 53.43% -0.28%
==========================================
Files 50 50
Lines 9408 9538 +130
Branches 1654 1685 +31
==========================================
+ Hits 5053 5097 +44
- Misses 4056 4130 +74
- Partials 299 311 +12 ☔ View full report in Codecov by Sentry. |
jesserockz
requested changes
Apr 16, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
can confirm this code works properly :) |
jesserockz
approved these changes
May 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Types of changes
Related issue or feature (if applicable): fixes esphome/issues#3537, fixes esphome/issues#4068, fixes esphome/issues#5534
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#2797
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: