Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graininess & streaks for 7.50inV2alt Waveshare e-paper #5168

Merged
merged 3 commits into from Aug 1, 2023

Conversation

Egglestron
Copy link
Contributor

This fix is based on demo files provided by Waveshare.

What does this implement/fix?

It resolves the graininess and streaking of previous versions of the library.
esphome/issues#2216

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#2216

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Example entry for config.yaml:

# Example config.yaml
external_components:
  - source:
      type: git
      url: https://github.com/egglestron/esphome
      ref: dev
    components: [ waveshare_epaper ]

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

This fix is based on demo files provided by Waveshare.
It resolves the graininess and streaking of previous versions of the library.
Comment on lines 1514 to 1515
// this->command(0x30);
// this->data(0x06); // 2-0=100: N=4 ; 5-3=111: M=7 ; 3C=50Hz 3A=100HZ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't comment out code, just remove it.

Removed OSC Setting for Waveshare e-paper
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging based on peoples comments on the linked issue

@jesserockz jesserockz added this to the 2023.7.1 milestone Aug 1, 2023
@jesserockz jesserockz merged commit 17be6b1 into esphome:dev Aug 1, 2023
25 checks passed
@jesserockz jesserockz mentioned this pull request Aug 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waveshare 7.5in V2 e-paper dim and grainy when using lines or rectangles
2 participants