Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graininess & streaks for 7.50inV2alt Waveshare e-paper #5168

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Fix graininess & streaks for 7.50inV2alt Waveshare e-paper #5168

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a089319
Fix graininess & streaks for 7.50inV2alt Waveshare e-paper
Egglestron Jul 30, 2023
7621daa
Merge branch 'dev' into dev
Egglestron Jul 30, 2023
64e8894
Remove useless commented code
Egglestron Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 5 additions & 6 deletions esphome/components/waveshare_epaper/waveshare_epaper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1493,11 +1493,10 @@ void WaveshareEPaper7P5InV2alt::initialize() {
this->command(0x01);

// 1-0=11: internal power
this->data(0x17);

this->data(0x07);
this->data(0x17); // VGH&VGL
this->data(0x3F); // VSH
this->data(0x3F); // VSL
this->data(0x26); // VSL
this->data(0x11); // VSHR

// VCOM DC Setting
Expand All @@ -1512,8 +1511,8 @@ void WaveshareEPaper7P5InV2alt::initialize() {
this->data(0x17);

// OSC Setting
this->command(0x30);
this->data(0x06); // 2-0=100: N=4 ; 5-3=111: M=7 ; 3C=50Hz 3A=100HZ
// this->command(0x30);
// this->data(0x06); // 2-0=100: N=4 ; 5-3=111: M=7 ; 3C=50Hz 3A=100HZ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't comment out code, just remove it.


// POWER ON
this->command(0x04);
Expand All @@ -1536,7 +1535,7 @@ void WaveshareEPaper7P5InV2alt::initialize() {
// COMMAND VCOM AND DATA INTERVAL SETTING
this->command(0x50);
this->data(0x10);
this->data(0x07);
this->data(0x00);
// COMMAND TCON SETTING
this->command(0x60);
this->data(0x22);
Expand Down