-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes load_settings
to UARTComponent
class
#5920
Conversation
This will expose `load_settings` (introduced on esphome#5909) to `UARTComponent` class and any component using that class. I'm changing this as I wanna Nextion component to be able to change it's baud rate on the communication with the display without the need to create temporary UART components to handle it.
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Following inline docs
Be aware with this PR, i got now compilation Error ..... was a breaking change ....
|
I will take a look at that later. |
ESP32 ... |
Yes I confirm breaking change for no good reason. It is ok that you add these fonctions as virtuals but NOT pure virtuals..... |
I cant do anything now because i am on a Phone but i will make a temp fix for you |
Wont show up with esp8266 because ifdef |
What does this implement/fix?
This will expose
load_settings
(introduced on #5909) toUARTComponent
class and any component using that class. I'm changing this as I wanna Nextion component to be able to change it's baud rate on the communication with the display without the need to create temporary UART components to handle it.Types of changes
Related issue or feature (if applicable): N/A
Pull request in esphome-docs with documentation (if applicable): N/A
Test Environment
Example entry for
config.yaml
:N/A
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: