-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert pure virtual functions in UART component from #5920 #5932
Conversation
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Rework fine now with this PR thx :) |
Thanks for your prompt response to this, @DrCoolzic. |
5aa04e7
to
abeecd8
Compare
abeecd8
to
1e1ec84
Compare
Sorry for using incorrect terminology. It seems like breaking change has a specific meaning in esphome Apprently C++ breaking changes to a component API (e.g. https://www.cppdepend.com/detect-api-breaking-changes) is not considered as a breaking change for esphome. As I understand it, this term only applies if the yaml configuration is to be changed. The interface change breaks the component I submitted 6 months ago, but as it hasn't been reviewed yet, it's still considered an external component. |
What does this implement/fix?
PR5920 has introduced a braking change by adding two PURE virtual functions. Therefore ANY class derived from UARTComponent will not compile anymore !!! Big badaboom
This fix keeps the two new virtual functions introduced in PR5920 but not as PURE VIRTUAL functions.
What's amazing is that there was absolutely no reason to make them pure virtual ???
For more info see my comment on #5920
Types of changes
Related issue or feature (if applicable): fixes
#5920
Test Environment
Example entry for
config.yaml
:NA
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: