Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UARTComponent inline doc #5930

Merged
merged 2 commits into from Dec 17, 2023
Merged

UARTComponent inline doc #5930

merged 2 commits into from Dec 17, 2023

Conversation

edwardtfn
Copy link
Contributor

@edwardtfn edwardtfn commented Dec 14, 2023

What does this implement/fix?

This adds inline docs to UARTComponent. There's no new functionality, but just to improve readability of the code and make it easier to use the API.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): N/A

Pull request in esphome-docs with documentation (if applicable): N/A

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

N/A

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@edwardtfn edwardtfn marked this pull request as ready for review December 14, 2023 15:05
@edwardtfn edwardtfn requested a review from a team as a code owner December 14, 2023 15:05
@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (uart) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit 94904f4 into esphome:dev Dec 17, 2023
44 checks passed
@jesserockz jesserockz added this to the 2023.12.0b3 milestone Dec 17, 2023
@jesserockz
Copy link
Member

Adding to the milestone because #5932 will cause conflicts if cherry picked without it

@edwardtfn
Copy link
Contributor Author

Should I do something to make it easier to resolve conflicts?
Can I do anything after it is merged?

jesserockz pushed a commit that referenced this pull request Dec 18, 2023
@jesserockz jesserockz mentioned this pull request Dec 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants