Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto load output for now #6309

Merged
merged 1 commit into from
Mar 5, 2024
Merged

auto load output for now #6309

merged 1 commit into from
Mar 5, 2024

Conversation

ssieb
Copy link
Member

@ssieb ssieb commented Mar 1, 2024

What does this implement/fix?

The output is optional for the speed fan but there was a compile error if there were no outputs defined.
This is a temporary fix until the template fan in #6310 is added.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#5541

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3654

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz merged commit 9644644 into esphome:dev Mar 5, 2024
58 checks passed
@kr0ner
Copy link

kr0ner commented Mar 5, 2024

@jesserockz & @ssieb thanks

jesserockz pushed a commit that referenced this pull request Mar 5, 2024
Co-authored-by: Samuel Sieb <samuel@sieb.net>
@jesserockz jesserockz mentioned this pull request Mar 5, 2024
@ssieb ssieb deleted the fan branch March 6, 2024 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speed_fan.h includes
3 participants