Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add template fan #6310

Merged
merged 5 commits into from
Mar 10, 2024
Merged

add template fan #6310

merged 5 commits into from
Mar 10, 2024

Conversation

ssieb
Copy link
Member

@ssieb ssieb commented Mar 1, 2024

What does this implement/fix?

This adds a template fan including adding the necessary triggers to the base fan component.
It also reverts the optional output change from #6274.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3655

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.53%. Comparing base (4d8b5ed) to head (d401c47).
Report is 66 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6310      +/-   ##
==========================================
- Coverage   53.70%   53.53%   -0.18%     
==========================================
  Files          50       50              
  Lines        9408     9507      +99     
  Branches     1654     1680      +26     
==========================================
+ Hits         5053     5090      +37     
- Misses       4056     4110      +54     
- Partials      299      307       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyrobi
Copy link
Member

nagyrobi commented Mar 1, 2024

Will presets of the template fan be independent from speed values?

Eg ability to just have presets like Auto, Manual, independent of speed...

@ssieb
Copy link
Member Author

ssieb commented Mar 1, 2024

Everything is independent. You can do whatever you want with the presets. Although I did see that changing any setting resets the preset back to no preset. But that's either HA or the base fan component.

@nagyrobi
Copy link
Member

nagyrobi commented Mar 1, 2024

Everything is independent. You can do whatever you want with the presets. Although I did see that changing any setting resets the preset back to no preset. But that's either HA or the base fan component.

Yes that's the problem. Manual is when you'd adjust by hand.
Auto would be when speed would be set by some sensor etc.
And you could of course have some fixed values too as shortcuts.

Don't think it's HA...

@ssieb
Copy link
Member Author

ssieb commented Mar 1, 2024

I think presets need a bit of work, but that's not for this PR.

@nagyrobi
Copy link
Member

nagyrobi commented Mar 1, 2024

#6112

@ssieb ssieb marked this pull request as ready for review March 7, 2024 06:59
@ssieb ssieb requested a review from a team as a code owner March 7, 2024 06:59
@ssieb ssieb merged commit 6a46548 into esphome:dev Mar 10, 2024
64 checks passed
@ssieb ssieb deleted the tfan branch March 10, 2024 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants