-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add template fan #6310
add template fan #6310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6310 +/- ##
==========================================
- Coverage 53.70% 53.53% -0.18%
==========================================
Files 50 50
Lines 9408 9507 +99
Branches 1654 1680 +26
==========================================
+ Hits 5053 5090 +37
- Misses 4056 4110 +54
- Partials 299 307 +8 ☔ View full report in Codecov by Sentry. |
Will presets of the template fan be independent from speed values? Eg ability to just have presets like |
Everything is independent. You can do whatever you want with the presets. Although I did see that changing any setting resets the preset back to no preset. But that's either HA or the base fan component. |
Yes that's the problem. Manual is when you'd adjust by hand. Don't think it's HA... |
I think presets need a bit of work, but that's not for this PR. |
What does this implement/fix?
This adds a template fan including adding the necessary triggers to the base fan component.
It also reverts the optional output change from #6274.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3655
Test Environment
Example entry for
config.yaml
:# Example config.yaml
Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: