Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32_rmt_led_strip bugfixes #6506

Merged
merged 2 commits into from
Apr 9, 2024
Merged

esp32_rmt_led_strip bugfixes #6506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddd5c50
Fix SM16703 timings
Mat931 Apr 9, 2024
923deb1
Fix buffer size calculation for WRGB led strips
Mat931 Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion esphome/components/esp32_rmt_led_strip/led_strip.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class ESP32RMTLEDStripLightOutput : public light::AddressableLight {
protected:
light::ESPColorView get_view_internal(int32_t index) const override;

size_t get_buffer_size_() const { return this->num_leds_ * (3 + this->is_rgbw_); }
size_t get_buffer_size_() const { return this->num_leds_ * (this->is_rgbw_ || this->is_wrgb_ ? 4 : 3); }

uint8_t *buf_{nullptr};
uint8_t *effect_data_{nullptr};
Expand Down
2 changes: 1 addition & 1 deletion esphome/components/esp32_rmt_led_strip/light.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class LEDStripTimings:
"WS2812": LEDStripTimings(400, 1000, 1000, 400),
"SK6812": LEDStripTimings(300, 900, 600, 600),
"APA106": LEDStripTimings(350, 1360, 1360, 350),
"SM16703": LEDStripTimings(300, 900, 1360, 350),
"SM16703": LEDStripTimings(300, 900, 900, 300),
}


Expand Down