Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp32_rmt_led_strip bugfixes #6506

Merged
merged 2 commits into from Apr 9, 2024

Conversation

Mat931
Copy link
Contributor

@Mat931 Mat931 commented Apr 9, 2024

What does this implement/fix?

  • Fix SM16703 timings
  • Fix buffer size calculation for WRGB led strips

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

probot-esphome bot commented Apr 9, 2024

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esp32_rmt_led_strip) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit 857b8ef into esphome:dev Apr 9, 2024
55 checks passed
This was referenced Apr 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@Mat931 Mat931 deleted the esp32-rmt-led-strip-bugfixes branch April 16, 2024 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants